Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup transitive package #475

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

k-gerner
Copy link
Contributor

Address vulnerability in older versions of rollup.

Added the following to package.json:

"resolutions": {
    "rollup": "4.22.4"
  }

Then ran
npx npm-force-resolutions
npm install

Then removed resolutions from package.json.

Ran tests and spun up test site to confirm build was working.

@k-gerner k-gerner requested a review from a team as a code owner November 13, 2024 18:37
Copy link
Contributor

Current unit coverage is 92.12481426448737%
Current visual coverage is 79.01234567901234%
Current combined coverage is 92.62376237623762%

@coveralls
Copy link

Coverage Status

coverage: 85.38%. remained the same
when pulling 3012da5 on dev/rollup-package-upgrade
into 76fb682 on hotfix/v1.6.6.

@k-gerner k-gerner merged commit a9ba7ac into hotfix/v1.6.6 Nov 13, 2024
20 checks passed
@k-gerner k-gerner deleted the dev/rollup-package-upgrade branch November 13, 2024 19:02
Copy link

@vijay267 vijay267 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why'd you remove the change in package.json itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants