ksearch: remove nested button #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerates package-lock.json to include the safe dependencies. J=VULN-39418, VULN-39419 TEST=none Saw that babel imports in package-lock.json and test-site/package-lock.json were for versions at or above the safe dependency.
The `npm run build` command was failing due to errors with the tsup build command. The increase in heap space is a temporary fix that we may run into again as the repo grows - the out of memory error that it prevents is an ongoing issue with the library itself (egoist/tsup#920).
The GeolocationPosition and GeolocationCoordinates objects now require toJSON() methods to be specified. Our implementation of these methods isn't important to my knowledge, but their absence is causing the LocationBias and Geolocation unit tests to fail.
Causing npm ci to fail when run remotely for automatic tests.
After making the library upgrades that were required to resolve vulnerabilities, new errors appeared that prevented our unit tests from passing. This commit updates the FilterSearch test so it passes without error.
Resolves errors that were being logged due to package upgrades in test files. These were prevent our automatic checks from passing.
This PR removes a button which was nested inside of a hyperlink. The button was only there for the onClick trigger, which can simply be moved to the hyperlink. Further, it is a violation of HTML5 to have HTML inside of a hyperlink, so this was a WCAG violation. J=TECHOPS-13454
|
Current unit coverage is 92.08312716476992% |
mkouzel-yext
approved these changes
Feb 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a button which was nested inside of a hyperlink. The button was only there for the onClick trigger, which can simply be moved to the hyperlink. Further, it is a violation of HTML5 to have HTML inside of a hyperlink, so this was a WCAG violation.
J=TECHOPS-13454