Skip to content

Commit

Permalink
remove aria labels, remove redundant addpage test
Browse files Browse the repository at this point in the history
  • Loading branch information
alextaing committed Sep 22, 2023
1 parent 6896629 commit 1364b8f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,13 @@ export default function LayoutSelector({
onChange={handleChange}
aria-label="Layout picker"
>
<option value="" aria-label="No layout selected">
<option>
No layout selected
</option>
{Object.keys(layouts).map((layoutName) => (
<option
key={layoutName}
value={layoutName}
aria-label={`${layoutName} layout`}
>
{layoutName}
</option>
Expand Down
10 changes: 0 additions & 10 deletions packages/studio-ui/tests/store/createPageSlice/pageActions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,6 @@ describe("addPage", () => {
},
});
});

it("gives an error for a filepath with a page name that already exists", () => {
const action = () =>
useStudioStore.getState().pages.addPage("universal", {
componentTree: [],
cssImports: [],
filepath: "/blah/universal.tsx",
});
expect(action).toThrowError('Page name "universal" is already used.');
});
});

describe("removePage", () => {
Expand Down

0 comments on commit 1364b8f

Please sign in to comment.