Skip to content

Commit

Permalink
Use studio-plugin version in package.json instead of wildcard (#355)
Browse files Browse the repository at this point in the history
In npm workspaces, you can use `*` to point to a local dependency (i.e.
another package), which is how we add `studio-plugin` as a dependency of
`studio`. This dependency is preserved as a symlink in the root
`package-lock.json`. Since the dependency version of `studio-plugin` in
the `studio` `package.json` was `*`, there was not a concrete version of
`studio-plugin` specified, so users had to explicitly install `studio`
and `studio-plugin`. This PR finds that we can still specify a version
of `studio-plugin` in the `studio` `package.json` and still preserve the
symlink for local development.

J-SLAP-2895
TEST=manual
  • Loading branch information
alextaing authored Aug 29, 2023
1 parent ba27f0c commit 2244f4d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/studio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@minoru/react-dnd-treeview": "^3.4.1",
"@restart/ui": "^1.5.2",
"@vitejs/plugin-react": "^4.0.4",
"@yext/studio-plugin": "*",
"@yext/studio-plugin": "0.20.0",
"autoprefixer": "^10.4.14",
"cac": "^6.7.14",
"classnames": "^2.3.2",
Expand Down

0 comments on commit 2244f4d

Please sign in to comment.