Skip to content

Commit

Permalink
Automated linting update and features.json sync
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] committed Oct 25, 2023
1 parent 357bb44 commit 4034943
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
22 changes: 14 additions & 8 deletions e2e-tests/tests/infra/StudioPlaywrightPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,19 @@ export default class StudioPlaywrightPage {
*/
async waitForLoadState() {
await this.page.waitForLoadState();
const overlayDomEl = this.page.getByTestId("loading-overlay")
await expect.poll(() => overlayDomEl.evaluate((e: HTMLElement) => {
console.log(e.className)
return e.className.includes("opacity-0")
}), {
message: "Waiting for LoadingOverlay to finish.",
timeout: 5000,
}).toBeTruthy()
const overlayDomEl = this.page.getByTestId("loading-overlay");
await expect
.poll(
() =>
overlayDomEl.evaluate((e: HTMLElement) => {
console.log(e.className);
return e.className.includes("opacity-0");
}),
{
message: "Waiting for LoadingOverlay to finish.",
timeout: 5000,
}
)
.toBeTruthy();
}
}
4 changes: 3 additions & 1 deletion packages/studio-ui/src/components/LoadingOverlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ export default function LoadingOverlay(

return (
<>
<div className={overlayClassname} data-testid="loading-overlay">{overlay}</div>
<div className={overlayClassname} data-testid="loading-overlay">
{overlay}
</div>
<div className={childrenWrapperClassname}>{props.children}</div>
</>
);
Expand Down

0 comments on commit 4034943

Please sign in to comment.