best tests thank you nmanu1

yext · Oct 24, 2023 · a576979 · a576979
1 parent 401f4aa
commit a576979
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/packages/studio-ui/src/components/UndoRedo.tsx b/packages/studio-ui/src/components/UndoRedo.tsx
@@ -25,7 +25,7 @@ export default function UndoRedo(): JSX.Element {
 
   const handleUndoKeydown = useCallback(
     (event: KeyboardEvent) => {
-      const actionKey = ["OS X", "Darwin"].includes(platform.os.family)
+      const actionKey = platform.os.family === "OS X"
         ? event.metaKey
         : event.ctrlKey;
       if (actionKey && event.key === "z") {

diff --git a/packages/studio-ui/tests/components/UndoRedo.test.tsx b/packages/studio-ui/tests/components/UndoRedo.test.tsx
@@ -7,6 +7,15 @@ import { searchBarComponent } from "../__fixtures__/componentStates";
 import mockStore from "../__utils__/mockStore";
 import platform from "platform";
 
+jest.mock("platform", () => ({
+  __esModule: true,
+  default: {
+    os: {
+      family: null
+    }
+  }
+}))
+
 describe("Undo/redo", () => {
   beforeEach(() => {
     jest.useFakeTimers();
@@ -47,15 +56,25 @@ describe("Undo/redo", () => {
     expect(useStudioStore.getState().pages.activeComponentUUID).toBeUndefined();
   });
 
-  it("undoes last state update using control/command + z", async () => {
-    const actionKey = ["OS X", "Darwin"].includes(platform.os.family)
-      ? "Meta"
-      : "Control";
+  it("undoes last state update using control + z", async () => {
+    platform.os.family = "Windows"
+
+    render(<UndoRedo />);
+    expect(useStudioStore.getState().pages.activeComponentUUID).toBe(
+      "searchbar-uuid"
+    );
+    await userEvent.keyboard("{Control>}z{/Control}");
+    expect(useStudioStore.getState().pages.activeComponentUUID).toBeUndefined();
+  });
+
+  it("undoes last state update using command + z", async () => {
+    platform.os.family = "OS X"
+
     render(<UndoRedo />);
     expect(useStudioStore.getState().pages.activeComponentUUID).toBe(
       "searchbar-uuid"
     );
-    await userEvent.keyboard(`{${actionKey}>}z{/${actionKey}}`);
+    await userEvent.keyboard("{Meta>}z{/Meta}");
     expect(useStudioStore.getState().pages.activeComponentUUID).toBeUndefined();
   });