studio-ui bundling #368
Merged
studio-ui bundling #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Safelist into studio-plugin
oshi97
force-pushed
the
dev/bundling
branch
from
dea4667 to
3f4e1dc
Compare
oshi97
force-pushed
the
dev/bundling
branch
from
f653aab to
a0f0904
Compare
This PR removes top-level fragments from the component tree of each layout in the layout slice so they won't be displayed in the UI when adding a layout to a new page. HMR is also updated to re-sync layouts in the store when a layout file is changed or a full sync is performed. J=SLAP-2937 TEST=manual In the test-site, saw that if `LocationLayout` had a top-level fragment, it was not present in the component tree in the `layouts` record. Also, checked that updating `LocationLayout` while running the test-site would correctly update it's component tree in the store.
oshi97
force-pushed
the
dev/bundling
branch
from
a0f0904 to
b9e2d01
Compare
oshi97
force-pushed
the
dev/bundling
branch
from
d025d74 to
cc44ac1
Compare
oshi97
force-pushed
the
dev/bundling
branch
from
5385c68 to
480a54d
Compare
tmeyer2115
reviewed
Sep 20, 2023
tmeyer2115
approved these changes
Sep 20, 2023
alextaing
pushed a commit
that referenced
this pull request
Sep 20, 2023
Bundles studio-ui to reduce multiple round trips made by the browser to the vite dev server. The browser still makes network requests for things like localData and component files. One way to reduce perceived lag here is server side rendering studio. Another is the loading indicator we have planned. DOMContentLoaded is now 412ms instead of 5.09s. There should be a bigger improvement in CBD due to network requests taking longer there compared to local. 5.0MB transferred instead of 14.6MB (could be smaller probably but still yay!) Removes ts-morph/typescript dependencies from TypeGuards and by extension the ui bundle (they are big packages). Updates lodash imports to use smaller scoped imports. Adds vite plugins for bundle size, css in js, dts files, and svg imports. J=SLAP-2921 TEST=manual I can start up studio and see less requests in the network tab old network tab https://github.com/yext/studio/assets/23005393/022d6199-5fa6-47db-b84b-5e543c729ae3 new network tab 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundles studio-ui to reduce multiple round trips made by the browser to the vite dev server.
The browser still makes network requests for things like localData and component files.
One way to reduce perceived lag here is server side rendering studio.
Another is the loading indicator we have planned.
DOMContentLoaded is now 412ms instead of 5.09s.
There should be a bigger improvement in CBD due to network requests taking longer there compared to local.
5.0MB transferred instead of 14.6MB (could be smaller probably but still yay!)
Removes ts-morph/typescript dependencies from TypeGuards and by extension the ui bundle (they are big packages).
Updates lodash imports to use smaller scoped imports.
Adds vite plugins for bundle size, css in js, dts files, and svg imports.
J=SLAP-2921
TEST=manual
I can start up studio and see less requests in the network tab
old network tab
Screen.Recording.2023-09-08.at.1.06.03.PM.mov
new network tab
