Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layouts via AddElementMenu #375

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Add Layouts via AddElementMenu #375

merged 14 commits into from
Sep 19, 2023

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented Sep 15, 2023

This PR implements adding layouts via the AddElementMenu/Button.

J=SLAP-2924
TEST=manual,auto

I can add layouts multiple times, set the newly added components as active, and save to file
updated AddElementMenu tests

@oshi97 oshi97 changed the title Dev/add layouts via menu Add Layouts vs AddElementMenu Sep 15, 2023
@oshi97 oshi97 requested a review from a team September 15, 2023 18:24
@oshi97 oshi97 changed the title Add Layouts vs AddElementMenu Add Layouts via AddElementMenu Sep 15, 2023
@oshi97 oshi97 removed the request for review from a team September 15, 2023 18:29
@oshi97 oshi97 requested a review from a team September 18, 2023 18:22
@oshi97 oshi97 marked this pull request as ready for review September 18, 2023 18:22
@oshi97 oshi97 merged commit 522a18f into main Sep 19, 2023
@oshi97 oshi97 deleted the dev/add-layouts-via-menu branch September 19, 2023 15:26
@tmeyer2115 tmeyer2115 mentioned this pull request Sep 22, 2023
tmeyer2115 added a commit that referenced this pull request Sep 22, 2023
## Features
- We've introduced the concept of Page Layouts (or Layouts) to Studio. A
Page Layout is a pre-prescribed set of Components that you can apply to
a Page. By default, Layouts live in the `src/layouts` directory. In the
UI, a Layout can be applied via the "Insert" button. (#370, #367, #375)
- There is now improved UX for creating or editing an Entity Page's
Stream Scope. Instead of being raw inputs, the fields for Entity Ids,
Entity Types, and Saved Filters are now drop-downs with the relevant
options populated from the account. (#380)

## Changes
- Repeaters and Modules have been officially deprecated and removed from
Studio. (#369)
alextaing pushed a commit that referenced this pull request Sep 22, 2023
## Features
- We've introduced the concept of Page Layouts (or Layouts) to Studio. A
Page Layout is a pre-prescribed set of Components that you can apply to
a Page. By default, Layouts live in the `src/layouts` directory. In the
UI, a Layout can be applied via the "Insert" button. (#370, #367, #375)
- There is now improved UX for creating or editing an Entity Page's
Stream Scope. Instead of being raw inputs, the fields for Entity Ids,
Entity Types, and Saved Filters are now drop-downs with the relevant
options populated from the account. (#380)

## Changes
- Repeaters and Modules have been officially deprecated and removed from
Studio. (#369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants