Layouts in add page flow #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
force-pushed
the
dev/layouts-in-add-page-flow
branch
from
4df5dd5 to
28cd2f3
Compare
alextaing
force-pushed
the
dev/layouts-in-add-page-flow
branch
from
4b19926 to
1155599
Compare
tmeyer2115
reviewed
Sep 21, 2023
packages/studio-ui/src/components/AddPageButton/AddPageButton.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/components/AddPageButton/BasicPageDataCollector.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/components/AddPageButton/LayoutSelector.tsx
Outdated
Show resolved
Hide resolved
nmanu1
reviewed
Sep 21, 2023
packages/studio-ui/src/components/AddPageButton/AddPageContext.ts
Outdated
Show resolved
Hide resolved
packages/studio-ui/tests/components/AddPageFlow/AddPageButton.test.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/tests/components/AddPageFlow/AddPageButton.test.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/tests/components/AddPageFlow/AddPageButton.test.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/components/AddPageButton/LayoutSelector.tsx
Outdated
Show resolved
Hide resolved
oshi97
reviewed
Sep 21, 2023
packages/studio-ui/src/components/AddPageButton/AddPageContextProvider.tsx
Outdated
Show resolved
Hide resolved
oshi97
reviewed
Sep 21, 2023
packages/studio-ui/src/components/AddPageButton/LayoutSelector.tsx
Outdated
Show resolved
Hide resolved
nmanu1
reviewed
Sep 21, 2023
nmanu1
reviewed
Sep 21, 2023
packages/studio-ui/src/components/AddPageButton/LayoutSelector.tsx
Outdated
Show resolved
Hide resolved
## Features - We've introduced the concept of Page Layouts (or Layouts) to Studio. A Page Layout is a pre-prescribed set of Components that you can apply to a Page. By default, Layouts live in the `src/layouts` directory. In the UI, a Layout can be applied via the "Insert" button. (#370, #367, #375) - There is now improved UX for creating or editing an Entity Page's Stream Scope. Instead of being raw inputs, the fields for Entity Ids, Entity Types, and Saved Filters are now drop-downs with the relevant options populated from the account. (#380) ## Changes - Repeaters and Modules have been officially deprecated and removed from Studio. (#369)
tmeyer2115
reviewed
Sep 22, 2023
packages/studio-ui/src/components/AddPageButton/StreamScopeCollector.tsx
Outdated
Show resolved
Hide resolved
tmeyer2115
approved these changes
Sep 22, 2023
oshi97
approved these changes
Sep 22, 2023
Merged
alextaing
added a commit
that referenced
this pull request
Sep 26, 2023
## Features - Layouts can now be added when adding a page. This new step is at the very end of the Add Page process (#376). - The Live Preview Button now opens up to the current active page instead the PageJS landing page (#379). ## Changes - Updated icons for Components, Containers, and Layouts (#378)! - The current selected viewport is now highlighted in the dropdown to keep track of the current viewport (#386). ## Fixes - The page settings now correctly refers to scope as "Content Scope" (#381). - Buggy deploy button behavior has been fixed (#385).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds layout selection to the end of the add page flow. An e2e test was written to test creating a static page using a simple layout. Unit tests were updated to test layouts as a part of the add page flow.
J=SLAP-2925
TEST=auto,manual