Live Preview Button Opens the Corresponding Static/Entity Page. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
changed the title
alextaing
reviewed
Sep 21, 2023
alextaing
reviewed
Sep 21, 2023
oshi97
reviewed
Sep 22, 2023
tmeyer2115
force-pushed
the
dev/update-preview-button
branch
from
16d6106 to
bc76c85
Compare
Merged
alextaing
added a commit
that referenced
this pull request
Sep 26, 2023
## Features - Layouts can now be added when adding a page. This new step is at the very end of the Add Page process (#376). - The Live Preview Button now opens up to the current active page instead the PageJS landing page (#379). ## Changes - Updated icons for Components, Containers, and Layouts (#378)! - The current selected viewport is now highlighted in the dropdown to keep track of the current viewport (#386). ## Fixes - The page settings now correctly refers to scope as "Content Scope" (#381). - Buggy deploy button behavior has been fixed (#385).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the "Live Preview" button. Previously, this button would open the PagesJS Landing Page in a new tab. Now, it opens a PagesJS-powered preview of the active Page in Studio. If the active Page is an Entity Page, the preview uses the currently selected Entity in Studio. There are a couple scenarios in which the Live Preview button will be disabled:
In a later PR, I will add a Tooltip that appears when the button is disabled. It will explain why it's disabled. In this PR, I also removed the "Open Live Preview" Acceptance test. I don't think that test adds much value any more. We have extensive unit test coverage for the Live Preview button. This coverage ensures that, when enabled,
window.openis called with the correct URL. We can assume thatwindow.openworks correctly. We already have various screenshots that capture the button (in both the enabled and disabled state). So, we've already got visual regression coverage.TEST=auto,manual
Ensured all the new unit tests passed. Using the Test Site, I verified that the proper Preview tab opened for both a Static and Entity page.