Required weekday field for teamcity_build_trigger_schedule with weekl…

…y schedule (#14)

For teamcity_build_trigger_schedule resources, if the schedule is weekly, the weekday field must be set

teamcity/resource_build_trigger_schedule.go

@@ -2,6 +2,7 @@ package teamcity
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/hashicorp/terraform/helper/validation"
@@ -194,7 +195,10 @@ func resourceBuildTriggerScheduleCreate(d *schema.ResourceData, meta interface{}
 	timezone := d.Get("timezone").(string)
 	rules := expandStringSlice(d.Get("rules").([]interface{}))
 	schedule := d.Get("schedule").(string)
-	weekday, _ := parseWeekday(d.Get("weekday").(string))
+	weekday, err := parseWeekday(d.Get("weekday").(string))
+	if err != nil {
+		return err
+	}
 
 	opt, err := expandTriggerScheduleOptions(d)
 	if err != nil {
@@ -210,6 +214,13 @@ func resourceBuildTriggerScheduleCreate(d *schema.ResourceData, meta interface{}
 		}
 	}
 
+	if strings.EqualFold(schedule, "weekly") {
+		triggerWeekday, ok := d.GetOk("weekday")
+		if !ok {
+			return fmt.Errorf("weekday is required if a schedule of weekly is chosen")
+		}
+	}
+
 	dt, err := api.NewTriggerSchedule(schedule, buildConfigID, weekday, uint(hour), uint(minute), timezone, rules, cronSchedule, opt)
 	if err != nil {
 		return err

teamcity/structure.go

@@ -2,19 +2,20 @@ package teamcity
 
 import (
 	"fmt"
+	"strings"
 	"time"
 )
 
 var daysOfWeek = map[string]time.Weekday{}
 
 func init() {
 	for d := time.Sunday; d <= time.Saturday; d++ {
-		daysOfWeek[d.String()] = d
+		daysOfWeek[strings.ToLower(d.String())] = d
 	}
 }
 
 func parseWeekday(v string) (time.Weekday, error) {
-	if d, ok := daysOfWeek[v]; ok {
+	if d, ok := daysOfWeek[strings.ToLower(v)]; ok {
 		return d, nil
 	}