fix: hide constant value option if not defined #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwartofsky-yext
requested review from
mkilpatrick,
briantstephan,
benlife5 and
colton-demetriou
benlife5
previously approved these changes
Nov 12, 2024
Hides the constant value option if we don't have a configuration for it defined. For hours, we specifically do not want to allow constant values. Verified that constant value can be chosen for expected types, but not for hours.
jwartofsky-yext
force-pushed
the
hideHoursConstant
branch
from
1a749eb to
233c0c2
Compare
jwartofsky-yext
dismissed
benlife5’s stale review
The base branch was changed.
mkilpatrick
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the constant value option if we don't have a configuration for it defined.
For hours, we specifically do not want to allow constant values.
Verified that constant value can be chosen for expected types, but not for hours.