feat: add collapsible theme #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asanehisa
commented
Nov 18, 2024
•
asanehisa
commented
benlife5
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Nice! Two styling nits:
- Try to get the spacing around the border of warning at the top to match the spacing around the border of the theme sections
- Might need to consult with Aaron/design on this but the top level FieldLabels don't really look like what I'd expect for a dropdown heading/trigger (I created them, sorry about that haha 😬)
mkilpatrick
reviewed
Nov 18, 2024
mkilpatrick
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.