feat: add editor component #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get everything ready for development (scripts, packages, directories, etc)
Major refactor to pull everything needed for the editor out of VE starter and into this VE lib. Adds export of Editor and the useMessage hooks. Allows usage of Editor with solely puckConfig, templateMetaData, and document as props. Corresponding VE Starter refactor PR coming shortly. Untested.
mkilpatrick
reviewed
Jul 23, 2024
brian-baugher
force-pushed
the
editorComponent
branch
from
5a04e1d to
1799d98
Compare
Co-authored-by: Matt Kilpatrick <[email protected]>
brian-baugher
commented
Jul 26, 2024
![semgrep-code-yext[bot]](https://avatars.githubusercontent.com/u/931250?s=60&v=4){kind=small}
pnpm-lock.yaml
Outdated
Comment on lines
4163
to
4164
| [email protected]: | ||
| resolution: {integrity: sha512-4hLB8Py4zZce5s4yd9XzopqwVv/yGNhV1Bl8NTmCq1763HeK2+EwVTv+leGeL13Dnh2wfbqowVPXCIO0z4taYw==} |
There was a problem hiding this comment.
Legal Risk:
pako 1.0.11 was released under the Zlib license, a license currently prohibited by your organization. Merging is blocked until this is resolved
Recommendation:
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license
mkilpatrick
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor to pull everything needed for the editor out of VE starter and into this VE lib. Adds export of Editor and the useMessage hooks. Allows usage of Editor with solely puckConfig, templateMetaData, and document as props. Corresponding VE Starter refactor PR: YextSolutions/pages-visual-editor-starter#108