Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure temporary files are given legal filenames #126

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Ensure temporary files are given legal filenames #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/net/http_client.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ let wget r f =

let base = Filename.basename r.req_url.Url.short_file in
(* Base could be "." for http://site.com/ *)
let base = if base = "."
let base = if base = "." || base = "/"
then begin
let prng = Random.State.make_self_init () in
let rnd = (Random.State.bits prng) land 0xFFFFFF in
Comment on lines 441 to 442
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really strange why it just doesn't call Random.int
or even better - use mkstemps

Expand Down
Loading