Add AppImageBuilder #80

lulol · 2022-06-26T16:43:14Z

Builds an AppImage executable package with the mlnet+gui executable. #65 (comment)

git clone https://github.com/ygrek/mldonkey.git
cd mldonkey
./configure --enable-batch --disable-directconnect --disable-fasttrack --disable-gnutella --disable-gnutella2 --enable-gui=newgui2 --prefix=/usr
make

wget https://github.com/AppImageCrafters/appimage-builder/releases/download/v1.0.3/appimage-builder-1.0.3-x86_64.AppImage
chmod +x appimage-builder-1.0.3-x86_64.AppImage
ln -s packages/appimage/AppImageBuilder.yml AppImageBuilder.yml
./appimage-builder-1.0.3-x86_64.AppImage

To run the optional appimage-builder tests you need docker installed and permissions.

Builds an appimage with mlnet+gui executable. ygrek#65 (comment) git clone https://github.com/ygrek/mldonkey.git cd mldonkey ./configure --enable-batch --disable-directconnect --disable-fasttrack --disable-gnutella --disable-gnutella2 --enable-gui=newgui2 --prefix=/usr make wget https://github.com/AppImageCrafters/appimage-builder/releases/download/v1.0.3/appimage-builder-1.0.3-x86_64.AppImage appimage-builder-1.0.3-x86_64.AppImage To run the optional appimage-builder tests you need docker installed and permissions.

Copy opam to ocamlformat.opam to fix ocaml-ci workflow?

ygrek · 2024-07-30T00:38:21Z

thanks!
this needs a fix - since safe-string was merged the batch compilation of ocaml together with mldonkey is not working anymore, it was finally removed from configure script in aa29c83
The fix should be as simple as adding ocaml ocaml-findlib and liblablgtk2-ocaml-dev to the apt-get install and let CI verify

ygrek

as mentioned above need to apt install ocaml

packages/appimage/AppImageBuilder.yml

.github/workflows/appimage.yml

lulol · 2024-07-30T21:04:43Z

I'll take a look at my archives this weekend to try to remember how this works and implement the requested changes. Meanwhile my current replies are from memory.

Add ocaml ocaml-findlib and liblablgtk2-ocaml-dev to the apt-get install

lulol · 2024-07-31T22:18:17Z

Seems that ocaml-ci still is having the same issues not finding the opam files. ❓

From the example recipes https://appimage-builder.readthedocs.io/en/latest/intro/tutorial.html#creating-the-appimage - rm -rf AppDir | true

Update to 22.04 jammy repo, add app version from env and remove commented code

Update functions and build system versions. Add new dependencies. Create a VERSION file. Pack artifacts more logically. And requested changes.

Add version, arch and os labels to generated artifacts. Remove now unneeded VERSION file.

appimage-builder is currently only released for x86_64

Add HEAD commit short hash to artifacts version when mlnet version includes the git string

ygrek

please fix version extraction and it is ready to merge (the rest can improve later)
thanks a lot for this

ygrek · 2024-11-26T16:29:37Z

.github/workflows/appimage.yml

+        run:  sudo apt-get install -y --no-install-recommends autoconf ocaml ocaml-findlib liblablgtk2-ocaml-dev camlp4 libnum-ocaml-dev libminiupnpc-dev libnatpmp-dev libbz2-dev librsvg2-dev libmagic-dev libgtk2.0-dev liblablgtk2-ocaml-dev liblablgtk2-gl-ocaml-dev liblablgtk2-gnome-ocaml-dev libgd-dev
+
+      - name: Configure options
+        run:  ./configure --enable-batch --enable-upnp-natpmp --disable-directconnect --disable-fasttrack --disable-gnutella --disable-gnutella2 --enable-gui=newgui2


i think directconnect module is in good shape, enable it?

ygrek · 2024-11-26T16:40:21Z

.github/workflows/appimage.yml

+
+      - name: Save version
+        run:  |
+              VERSION=$(./mlnet -v 2>&1 | sed -ne "1s#^.*Starting MLDonkey \([^ ]\+\) .*#\1#p")


there should be better way to get version without running the binary. Worst case can grep configure log, or actually this :

$ ocaml -e '#use "src/utils/lib/autoconf.ml";; print_endline current_version' 3.2.1.git

see ocaml/ocaml#13637 for why less ugly methods don't work

ygrek · 2024-11-26T16:42:18Z

.github/workflows/appimage.yml

+  APPIMAGEBUILDER_SHA1SUM: 6f83a789f6c47a745b97d1b0b3f1df2e7eea7a09
+
+jobs:
+  build:


i think ideally this build part of pipeline should be move to main pipeline, and then here keep only appimage (and use artifacts produced by main build pipeline)

lulol added 6 commits June 26, 2022 16:34

Copy ocamlformat.opam

3b8c99b

Copy opam to ocamlformat.opam to fix ocaml-ci workflow?

Move AppImageBuilder.yml to the packages dir

19d7934

Move AppImageBuilder.yml to packages dir

e8cc362

Add workflow to manually build an mlnet+gui appimage

79b9e54

Delete ocamlformat.opam

81d5f0f

ygrek force-pushed the master branch from 06f7765 to 9bd6485 Compare July 29, 2024 04:56

ygrek requested changes Jul 30, 2024

View reviewed changes

packages/appimage/AppImageBuilder.yml Outdated Show resolved Hide resolved

packages/appimage/AppImageBuilder.yml Outdated Show resolved Hide resolved

packages/appimage/AppImageBuilder.yml Outdated Show resolved Hide resolved

.github/workflows/appimage.yml Outdated Show resolved Hide resolved

Add ocaml ocaml-findlib and liblablgtk2-ocaml-dev

32787ea

Add ocaml ocaml-findlib and liblablgtk2-ocaml-dev to the apt-get install

lulol added 4 commits August 1, 2024 17:32

remove pipe to true

c4a0308

From the example recipes https://appimage-builder.readthedocs.io/en/latest/intro/tutorial.html#creating-the-appimage - rm -rf AppDir | true

Merge branch 'ygrek:master' into lulol-appimagebuilder

172398f

Update versions and add requested changes

4fe024f

Update to 22.04 jammy repo, add app version from env and remove commented code

Update build system version, add requested changes

55986c9

Update functions and build system versions. Add new dependencies. Create a VERSION file. Pack artifacts more logically. And requested changes.

lulol requested a review from ygrek August 9, 2024 14:57

lulol added 2 commits August 10, 2024 16:44

Add version labels to generated artifacts

2a8ec5e

Add version, arch and os labels to generated artifacts. Remove now unneeded VERSION file.

Build appimage only for x86_64

85c0444

appimage-builder is currently only released for x86_64

lulol mentioned this pull request Aug 16, 2024

GTK2 build: error when compiling guiUtf8.ml: Unbound module Glib #111

Closed

lulol added 2 commits August 17, 2024 14:05

Merge branch 'ygrek:master' into lulol-appimagebuilder

493acca

Add static hash check for downloaded appimage-builder

75606ef

ygrek force-pushed the master branch 8 times, most recently from 338d5c9 to a7d5906 Compare August 27, 2024 00:37

ygrek force-pushed the master branch 6 times, most recently from 28754fe to 05908f6 Compare August 27, 2024 01:28

lulol added 2 commits October 20, 2024 14:36

Add HEAD commit hash to version

1e6d34e

Add HEAD commit short hash to artifacts version when mlnet version includes the git string

Merge branch 'ygrek:master' into lulol-appimagebuilder

51702ed

ygrek approved these changes Nov 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AppImageBuilder #80

Add AppImageBuilder #80

lulol commented Jun 26, 2022 •

edited

Loading

ygrek commented Jul 30, 2024

ygrek left a comment

lulol commented Jul 30, 2024

lulol commented Jul 31, 2024

ygrek left a comment

ygrek Nov 26, 2024

ygrek Nov 26, 2024

ygrek Nov 26, 2024

Add AppImageBuilder #80

Are you sure you want to change the base?

Add AppImageBuilder #80

Conversation

lulol commented Jun 26, 2022 • edited Loading

ygrek commented Jul 30, 2024

ygrek left a comment

Choose a reason for hiding this comment

lulol commented Jul 30, 2024

lulol commented Jul 31, 2024

ygrek left a comment

Choose a reason for hiding this comment

ygrek Nov 26, 2024

Choose a reason for hiding this comment

ygrek Nov 26, 2024

Choose a reason for hiding this comment

ygrek Nov 26, 2024

Choose a reason for hiding this comment

lulol commented Jun 26, 2022 •

edited

Loading