Implement the ability for user-defined type casting #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
=========================================
Coverage 99.23% 99.23%
- Complexity 1534 1540 +6
=========================================
Files 98 98
Lines 3804 3812 +8
=========================================
+ Hits 3775 3783 +8
Misses 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
requested changes
Mar 18, 2025
Co-authored-by: Alexander Makarov <[email protected]>
samdark
approved these changes
Mar 18, 2025
vjik
reviewed
Mar 25, 2025
| /** | ||
| * `JsonSerializable` interface is implemented to convert the object to a database representation. | ||
| */ | ||
| public function jsonSerialize(): array |
There was a problem hiding this comment.
May be to add another example with dbTypecast() . This allow to keep DTO clear, without infrastructure things.
| { | ||
| return match ($type) { | ||
| /** @psalm-var class-string<ColumnInterface> */ | ||
| return $this->mapType($this->columnClassMap, $type, $info) ?? match ($type) { |
There was a problem hiding this comment.
Extract match ($type) { ... to separate method. This allow to prevent duplicate $this->mapType(...) in yiisoft/db-* packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs