Ynezz/build improvements #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if get_git_commit_id() fails, its not clear why:
Generation for Bootloader to /build_dir has completed.
...snip...
File "/usr/lib/python3.11/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', '-C', '/build', 'rev-parse', 'HEAD']' returned non-zero exit status 128.
So lets fix it by providing stderr output, thus making the issue
obvious:
Generation for Bootloader to /build_dir has completed.
...snip...
File "/build/tools/build_project.py", line 113, in git
raise RuntimeError(
RuntimeError: Git command `git -C /build rev-parse HEAD` failed: fatal: detected dubious ownership in repository at '/build'
To add an exception for this directory, call:
git config --global --add safe.directory /build
Signed-off-by: Petr Štetiar <[email protected]>
Using the build workflow with rootless podman containers and volumes:
podman \
run --rm -it \
--privileged \
-v $(PWD)/build:/build:Z \
silabs-firmware-builder \
bash -c " \
cd /build && \
./tools/build_firmware.sh test.yml \
"
results into following permssions issue:
The sdk /simplicity_sdk_2024.6.2/ ( com.silabs.sdk.stack.sisdk:2024.6.2._-620023087 ) is now trusted.
ln: failed to create symbolic link '/simplicity_sdk_2024.6.2/extension': Permission denied
This is happening due to the user/group mapping between container and
the host and currently the simplicity_sdk_2024 directory is owned as
root, thus builder user won't be able to create an extension symlink,
resulting in this failure.
So lets fix it by chown-ing the simplicity_sdk_2024 for builder.
References: https://www.redhat.com/en/blog/debug-rootless-podman-mounted-volumes
Signed-off-by: Petr Štetiar <[email protected]>
ynezz
force-pushed
the
ynezz/build-improvements
branch
from
6afc062 to
efc5822
Compare
ynezz
force-pushed
the
ynezz/build-improvements
branch
4 times, most recently
from
3628dce to
f254e7b
Compare
Currently its not possible to easily reuse the steps taken on the GitHub CI to build firmware, so lets factor out those bits into new build_firmware.sh script help which basically mimics the current firmware build flow on the GitHub CI. Signed-off-by: Petr Štetiar <[email protected]>
Currently it needs a lot of steps to build single firmware, so lets streamline this workflow by using container. Usage: make [all|build_container|build_firmware] Targets: all Build container and firmware build_container Build container build_firmware Build firmware help Show this help message Options: build_firmware MANIFESTS=<path> Override default manifest files (default: all .yaml/.yml files in manifests/) Examples: # Build the container image make build_container # Build all firmware manifests make build_firmware # Build a specific firmware manifest make build_firmware MANIFESTS=manifests/nabucasa/yellow_bootloader.yaml Signed-off-by: Petr Štetiar <[email protected]>
Signed-off-by: Petr Štetiar <[email protected]>
ynezz
force-pushed
the
ynezz/build-improvements
branch
4 times, most recently
from
a7928ba to
dc58e6c
Compare
Signed-off-by: Petr Štetiar <[email protected]>
ynezz
force-pushed
the
ynezz/build-improvements
branch
from
9332d66 to
c4c82e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.