Chore: Display bitbake operators in purple and other overrides remain…

… as is
yoctoproject · Dec 22, 2023 · d117c28 · d117c28
1 parent e251c66
commit d117c28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/client/syntaxes/bitbake.tmLanguage.json b/client/syntaxes/bitbake.tmLanguage.json
@@ -265,7 +265,7 @@
         },
         "bitbake-operator": {
             "match": "(?<=:)(append|prepend|remove)",
-            "name": "keyword.other.bitbake-operator.bb"
+            "name": "keyword.control.bb"
         },
         "parenthesis-open": {
             "match": "([\\w])*\\(",

diff --git a/server/src/tree-sitter/utils.ts b/server/src/tree-sitter/utils.ts
@@ -77,20 +77,14 @@ export function isVariableReference (n: SyntaxNode): boolean {
   }
 }
 
+/**
+ * Check if the node is an override other than `append`, `preprend` or `remove`
+ */
 export function isOverride (n: SyntaxNode): boolean {
-  const parentTypes = [
-    'variable_assignment',
-    'function_definition',
-    'anonymous_python_function',
-    'python_function_definition'
-  ]
   const parentType = n?.parent?.type
   switch (n.type) {
-    case 'override':
-      if (parentType !== undefined) {
-        return parentTypes.includes(parentType)
-      }
-      return false
+    case 'identifier':
+      return parentType === 'override' // As per the tree-sitter grammar, an identifier which has a parent of type override is an override other than `append`, `preprend` or `remove`
     default:
       return false
   }