Chore: Use VS Code API to manage embedded languages files #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives better responsiveness when editing files
deribaucourt
approved these changes
Dec 1, 2023
|
So lets merge it with the embedded languages diagnostics: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR is preceding the merge of the diagnostics for the embedded languages, for which the integration tests are not yet ready.
It moves the "EmbeddedLanguageDocManager" to the client side, in order to be able to use the VS Code api to manage the files. Doing so gives a better responsiveness when editing the embedded language files. Otherwise, I had to create new files on every change in order to trigger the diagnostics on the embedded language documents (which was very bad)