Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESlint bump #324

Merged
merged 59 commits into from
Sep 26, 2024
Merged

Conversation

deribaucourt
Copy link
Member

No description provided.

@deribaucourt
Copy link
Member Author

Contains #300 #297 #277

@deribaucourt
Copy link
Member Author

The typescript config works, the extension properly compiles and runs.
However the eslint config must be written. It's awfully complex

@deribaucourt deribaucourt added the help wanted Extra attention is needed label Sep 16, 2024
@deribaucourt deribaucourt changed the title Tscript bump ESlint bump Sep 17, 2024
@deribaucourt
Copy link
Member Author

I integrated @idillon-sfl #324
Everything working it looks like!

@deribaucourt deribaucourt marked this pull request as ready for review September 18, 2024 08:38
@deribaucourt
Copy link
Member Author

I created a vsce PR to fix the workdir vscode-bitbake-lib symlink generating errors.
microsoft/vscode-vsce#1053
It looks like we'll have for it to be merged before the packaging works. Refering my commit fails to compile vsce's typescript.

Bumps [eslint-config-standard-with-typescript](https://github.com/mightyiam/eslint-config-standard-with-typescript) from 39.1.1 to 43.0.1.
- [Release notes](https://github.com/mightyiam/eslint-config-standard-with-typescript/releases)
- [Changelog](https://github.com/mightyiam/eslint-config-love/blob/main/CHANGELOG.md)
- [Commits](mightyiam/eslint-config-love@v39.1.1...v43.0.1)

---
updated-dependencies:
- dependency-name: eslint-config-standard-with-typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@deribaucourt
Copy link
Member Author

Closes #327
Closes #300
Closes #297
Closes #277

README-DEVELOPER.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
integration-tests/src/tests/rename.test.ts Show resolved Hide resolved
server/src/__tests__/fixtures/fixtures.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
README-DEVELOPER.md Outdated Show resolved Hide resolved
dependabot bot and others added 13 commits September 24, 2024 09:37
Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.83.1 to 1.92.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

---
updated-dependencies:
- dependency-name: "@types/vscode"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.5.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.2.2...v5.5.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
idillon-sfl and others added 25 commits September 24, 2024 09:37
The latest release is not yet compatible with our version of ESLint.
While awaiting the next release, we'll use a fork which has the fix.

See Stuk/eslint-plugin-header#57
This feature has always been available but now requires additional
global packages to be installed.

VSCode's ESLint extension does not run inside the project's environment.
Use `ncu -u` and `npm audit fix` to update dependencies.

We now have 0 warnings when running `npm install`.
@types/vscode must be downgraded a bit to be compatible.

The latest vsce 3.1.0 version does not work with workspaces which are
symlinks, which is the case for our "lib" folder. I created a fork
and PR to fix this issue, but in the meantime, we need to use the
commit hash of the fix.
No need to package this file.
This removes the tsbuildinfo cache. It forces `npm run compile` to
re-generate the client/out and server/out folders after a clean.
We cannot bump to the latest version of vsce because it introduces a
regression with our vscode-bitbake-lib symlink workspace. While awaiting
a fix upstream, revert to the last known good version.
The live linter must be configured to use our version of eslint and
plugins. Otherwise, a global install would be needed.
@deribaucourt deribaucourt merged commit c942ace into yoctoproject:staging Sep 26, 2024
5 checks passed
@deribaucourt deribaucourt deleted the tscript-bump branch September 26, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants