Devtool fixes and optim #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With kas-container or custom docker mount-points, the devtool-open-workspace command would fail to try to open the container's workspace path on the host system. Add the required logic to resolve the path to the host system. It's a bit tricky if the container's mount points are different between the sources and the build workspaces. We only support trivial cases for now which work with kas-container.
When using the devtool-update-recipe command in a container, the paths have to be resolved between host and container.
deribaucourt
force-pushed
the
devtool-next
branch
from
2b1c8bc to
9800c37
Compare
Settings change will provoke a rescan command. If it hasn't been called since the last sanity check, it doesn't need to be checked again. This noticeably speeds up the on save parsing and devtool modify command.
deribaucourt
force-pushed
the
devtool-next
branch
from
4a701f9 to
7659a63
Compare
Some tests only bother with providing recipes. Consider a scanResult to be valid if it contains either layers or recipes.
If bitbake sanity tests or parsing is stuck for some reason (buggy commandWrapper, filesystem issues, CPU load...), the extension freatures would get frozen.
Define the general timeout for running a bitbake parsing command as a constant. This will allow us to change the timeout in a single place. Note that this is not for regular bitbake builds which can take hours.
Sending bitbake when a terminal is closed may not be enough to kill it as it may take minutes before started tasks finish. Sending a second and third signal after a timeout ensures bitbake is stopped before a minute. Note that this does not work for docker containers yet: https://stackoverflow.com/a/50034061/20690788
New eslint extension updated it's settings.
deribaucourt
force-pushed
the
devtool-next
branch
from
7659a63 to
16d91a2
Compare
Bitbake requires multiple SIGINT signals to fully stop when stuck. Additionally, docker container processes are not properly killed by calling child.kill() on the shell process. We instead find the process PID and kill it directly.
The user will want to see the results of devtool modify/reset in the devtool workspaces view as soon as the command completes. Add a brief rescan of the devtool workspaces to the command handlers.
Fixes the following bugs: - Starting multiple bitbake processes at the same time would not open new terminals - Stopping a bitbake process that has not started yet would let it execute
If multiple commands where started at the same time, and we closed a terminal that was still waiting for the bitbake lock, it could have been reused.
deribaucourt
force-pushed
the
devtool-next
branch
from
5032f99 to
bda7639
Compare
idillon-sfl
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.