Minor fixes #50
Merged
Minor fixes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the sanity check runs `which devtool` which contains devtool, but is not a devtool command. Fix the logic to show the correct status.
If the first scan fails, properly render it instead of keeping the promise pending forever. During devtool modify, don't interpret the temporary scan results as valid.
This is the only command that doesn't spawn a terminal, so it's not obvious that it's done. Show a message to the user to let them know.
The deploy task won't work if the sshTarget is empty.
In case an eSDK is used, we should use the devtool commands instead of bitbake.
This command mimics the devtool deploy-target task which is found also in the SDK fallback.
Scanning is very slow. We only want to run it if a setting that is suceptible to change it's output was modified. Now, changing the logging level, the SDK args or the parseOnSave won't trigger a rescan.
deribaucourt
force-pushed
the
minor-fixes
branch
from
4105bb3 to
0cb68a5
Compare
ioioioio
approved these changes
Jan 8, 2024
idillon-sfl
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.