Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI item icons #53

Conversation

WilsonZiweiWang
Copy link
Contributor

@WilsonZiweiWang WilsonZiweiWang commented Jan 5, 2024

Sample results:
image

  1. Moving Add an extra add-recipe operation with the plus icon to the title which can make adding recipes easier in case the list gets too long.
    2. Use less ambiguous icons for the build recipe and clean recipe operations

Icon references: https://code.visualstudio.com/api/references/icons-in-labels

@deribaucourt
Copy link
Member

Elinor's feedback sounded like the new icons are not specially more meaningful. Also it would cause confusion to users of the previous version that now know them. I advise to keep those UI elements as they currently are. I like the additional button for adding a recipe to the list though. But we should also keep the previous one.

@ghost
Copy link

ghost commented Jan 8, 2024

I think both icons are not the best for a build action, when I think of building I think more of a hammer for example.
But if Enguerrand's icon is also used for build actions in other extensions like CMake, I think it's a better idea.
Also the new icon for "clean" is not representative of the action for me.

@WilsonZiweiWang
Copy link
Contributor Author

Okay, I will abandon the new icons but only keep the extra add icon in the title.

@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review January 8, 2024 16:01
@WilsonZiweiWang WilsonZiweiWang merged commit 0892337 into yoctoproject:staging-next Jan 8, 2024
1 check passed
@WilsonZiweiWang WilsonZiweiWang deleted the Update-UI-item-icons branch January 8, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants