Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors not matched by problem matcher #54

Conversation

WilsonZiweiWang
Copy link
Contributor

@WilsonZiweiWang WilsonZiweiWang commented Jan 5, 2024

Removed bitbake-generic since it could cover a wide range of error messages. Precise ones should be used to avoid overlap since they differ in the positions of the line numbers.

deribaucourt
deribaucourt previously approved these changes Jan 8, 2024
client/package.json Outdated Show resolved Hide resolved
@deribaucourt deribaucourt dismissed their stale review January 9, 2024 10:22

The merge-base changed after approval.

@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch from 7f9d619 to 66823ad Compare January 9, 2024 16:02
@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review January 9, 2024 16:20
@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch from 66823ad to 47126b2 Compare January 9, 2024 16:23
client/package.json Show resolved Hide resolved
client/package.json Outdated Show resolved Hide resolved
@WilsonZiweiWang WilsonZiweiWang changed the title Fix incorrect underline in problem matching Fix some errors not matched by problem matcher Jan 9, 2024
@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch from 6faa731 to 19d3fc7 Compare January 9, 2024 18:11
@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch 2 times, most recently from db82798 to 7516034 Compare January 10, 2024 21:11
@WilsonZiweiWang
Copy link
Contributor Author

I think I only see the code that adds the build folder but how bblayers.conf was added was not clear to me @deribaucourt

@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch from 3f77dda to 5785cfa Compare January 11, 2024 16:08
Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
The only remaining thing is to add the examples for bitbake-variable and bitbake-task-error.

@deribaucourt
Copy link
Member

You can rebase this PR and target staging.

@WilsonZiweiWang WilsonZiweiWang changed the base branch from staging-next to staging January 12, 2024 16:03
@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch from 5cb01dd to ced3d68 Compare January 12, 2024 16:18
@WilsonZiweiWang WilsonZiweiWang force-pushed the Bug-13883-problemMatcher-correct-underlining branch from ced3d68 to 62f4913 Compare January 12, 2024 16:21
Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improves most errors, great job!

@WilsonZiweiWang WilsonZiweiWang merged commit 9174fd9 into yoctoproject:staging Jan 29, 2024
2 checks passed
@WilsonZiweiWang WilsonZiweiWang deleted the Bug-13883-problemMatcher-correct-underlining branch January 29, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants