Don't log connection-uri on connection failure #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An aggressive fix for #189 It simply replaces a non-empty string entirely, to avoid the difficulties in parsing the uri and removing only the password.
|
This looks reasonable to me as an immediate fix. I agree that logging the password is definitely worse than the alternative. Just pushed out 1.3.1 to Clojars with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An aggressive fix for issue 189
It simply replaces a non-empty string entirely, to avoid the difficulties of parsing the uri and removing only the password.
(This was suggested as an option by @jysandy when creating the bug.)
While not ideal, this is better than logging a password.
Can we consider showing more information in this case as a future enhancement?
Context: luminus-migrations seem to require passing a URI rather than a db-spec, so issue 189 affects all users of that library.