Don't log value of :connection-uri in db-spec #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for yogthos#189 When logging the db-spec on a connection failure, it replaces a non-empty value for key :connection-uri entirely, to avoid the difficulties of parsing the uri and removing only the password.
whenceforth
commented
Oct 21, 2020
| (censor-password | ||
| "jdbc:postgresql://fake.example.org/my_dev?user=my_user&password=thisIsNot123ARealPass"))) | ||
| (is (= {:connection-uri "uri-censored"} | ||
| (censor-password {:connection-uri "jdbc:postgresql://fake.example.org/my_dev?user=my_user&password=thisIsNot123ARealPass"}))) |
There was a problem hiding this comment.
Unfortunately, my previous change did not handle the case of a map with key :connection-uri, which is what occurs when migratus is called from luminus-migrations.
|
Ah thanks for the update, pushed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #189
When logging the db-spec on a connection failure, it replaces a non-empty value
for key :connection-uri entirely, to avoid the difficulties of parsing the uri
and removing only the password.