Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli options #244

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Cli options #244

merged 7 commits into from
Jul 14, 2023

Conversation

sandre1
Copy link
Contributor

@sandre1 sandre1 commented Jul 12, 2023

work in progress on migratus #240

  • add CLI interface to migratus (migratus.cli)
  • improve logging - add logs for the migratus create actions and others
  • expose an API functionality to list the migrations ID-s from the CLI

what i have added so far

  • added CLI interface to migratus (cli.clj)
  • programatic configuration for JUL, to display only the log message, less noise.
    The logger is configured to print only the text message, without timestamp.

The work is in progress, so be gentle :)
I need some reviews from you guys if you have the time.
Thank you.

src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
@yogthos
Copy link
Owner

yogthos commented Jul 12, 2023

Overall looks good, I added a few small nitpicks, but otherwise I'm happy to merge this in.

@sandre1
Copy link
Contributor Author

sandre1 commented Jul 14, 2023

Hi, thank you for your input, new things learned :).
I have also refactored the set-logger-format function to a multy-arity fn.
Forward, i want to add logs for some of the migratus core actions.
From my side, it is ready to merge, i will make a PR with the other stuff.

@yogthos yogthos merged commit 38f5a1c into yogthos:master Jul 14, 2023
@yogthos
Copy link
Owner

yogthos commented Jul 14, 2023

Great, should I push a new version up to Clojars or would you like to wait for the other PR?

@sandre1
Copy link
Contributor Author

sandre1 commented Jul 14, 2023

Great, should I push a new version up to Clojars or would you like to wait for the other PR?

I think it is better to wait for other PR with complete, tested functionality. thank you.

@yogthos
Copy link
Owner

yogthos commented Jul 14, 2023

Sounds like a plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants