Valvat::Options#check_uk_key: Fixed missing silence variable

* Added spec
* Better deprecation warning message
Issue #141

Author: yolk

lib/valvat/options.rb

@@ -19,7 +19,7 @@ def initialize(options, silence: false)
         end
       end
 
-      check_uk_key
+      check_uk_key(silence)
     end
 
     def [](key)
@@ -32,11 +32,11 @@ def dig(*keys)
 
     private
 
-    def check_uk_key
+    def check_uk_key(silence)
       return if @options[:uk] != true || silence
 
       puts 'DEPRECATED: The option :uk is not allowed to be set to `true` anymore. ' \
-           'Using the HMRC API requires authentication credentials.'
+           'Instead it needs to be set to your HMRC API authentication credentials.'
     end
   end
 

spec/valvat/options_spec.rb

@@ -46,5 +46,16 @@
         end.to output("DEPRECATED: The option :savon is deprecated. Use :http instead.\n").to_stdout
       end
     end
+
+    context 'when options contains deprecated key uk set to true' do
+      it 'prints deprecation warning' do
+        expect do
+          described_class.new({ uk: true })
+        end.to output(
+          'DEPRECATED: The option :uk is not allowed to be set to `true` anymore. ' \
+          "Instead it needs to be set to your HMRC API authentication credentials.\n"
+        ).to_stdout
+      end
+    end
   end
 end