Move Presence from Client to Document and replace selection with presence #130
Conversation
- fix tree edit - add pathToIndex in JsonTree
| /** | ||
| * [PresenceProxy] represents a proxy for the Presence to be manipulated from the outside. | ||
| */ | ||
| public data class PresenceProxy internal constructor( |
There was a problem hiding this comment.
I think we should remove 'Proxy' from the class name, since the users shouldn't have to know whether it is a proxy or not.
There was a problem hiding this comment.
I renamed it to Presence in this commit.
| private val actorID: ActorID, | ||
| ) { | ||
|
|
||
| public fun set(data: Map<String, String>) { |
There was a problem hiding this comment.
set could be a little misleading as it may imply that previous presence data would be overriden by new data map.
Maybe we should use put instead, or we could change the parameter type to collection of pairs of strings.
There was a problem hiding this comment.
I changed the function name as put in this commit.
- Presence -> P - fix presences emission
|
In 77ab8e1, several adjustments have been made to maintain |
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 83.05% 82.46% -0.60%
==========================================
Files 63 64 +1
Lines 3654 3696 +42
Branches 534 563 +29
==========================================
+ Hits 3035 3048 +13
- Misses 325 343 +18
- Partials 294 305 +11
|
What this PR does / why we need it?
Any background context you want to provide?
This PR builds upon the changes introduced in the following PR:
What are the relevant tickets?
Fixes #
Checklist