Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yossy.devでisolatedDeclationを有効にしてtscの速度を測る #78

Merged
merged 6 commits into from
Dec 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ bun.lockb
localhost-key.pem
localhost.pem

## typecheck:perfomance
trace.json
types.json
7 changes: 7 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"editor.defaultFormatter": "biomejs.biome",
"editor.codeActionsOnSave": {
"source.organizeImports.biome": "explicit",
"quickfix.biome": "explicit"
}
}
2 changes: 1 addition & 1 deletion app/global.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {} from "hono";

type Head = {
export type Head = {
title?: string;
description?: string;
date?: string;
Expand Down
2 changes: 1 addition & 1 deletion app/hooks/useDebounce.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useEffect, useState } from "hono/jsx";

export function useDebounce(value: number, delay: number) {
export function useDebounce(value: number, delay: number): number {
const [debouncedValue, setDebouncedValue] = useState(value);

useEffect(() => {
Expand Down
2 changes: 1 addition & 1 deletion app/libs/date.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const birthday = {
date: 24,
};

export function getAge() {
export function getAge(): number {
const today = new Date();
const thisYearsBirthday = new Date(
today.getFullYear(),
Expand Down
21 changes: 18 additions & 3 deletions app/libs/rss/rss.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ function formatDate(utcDate: string) {
}

export const rssClient = {
find() {
find(): {
id: string;
title: string;
date: string;
link: string;
}[] {
return zennRss.map((item) => ({
id: item.guid,
title: item.title,
Expand All @@ -20,7 +25,12 @@ export const rssClient = {
}));
},

findYoutube() {
findYoutube(): {
id: string;
title: string;
date: string;
link: string;
}[] {
return youtubeRss.map((item) => ({
id: item.id,
title: item.title,
Expand All @@ -29,7 +39,12 @@ export const rssClient = {
}));
},

findSpeakerdeck() {
findSpeakerdeck(): {
id: string;
title: string;
date: string;
link: string;
}[] {
return speakerdeckRss.map((item) => ({
id: item.guid,
title: item.title,
Expand Down
2 changes: 1 addition & 1 deletion app/libs/vite-remark-toc-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface Heading extends Element {
}

function rehypeTOC() {
return (tree: Root) => {
return (tree: Root): void => {
const headings: Heading[] = [];
visit(tree, "element", (node: Element) => {
if (node.tagName === "h2" || node.tagName === "h3") {
Expand Down
3 changes: 2 additions & 1 deletion app/routes/_renderer.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { MiddlewareHandler } from "hono";
import { jsxRenderer } from "hono/jsx-renderer";
import { Script } from "honox/server";
import { LINK } from "../constants";
Expand Down Expand Up @@ -87,4 +88,4 @@ export default jsxRenderer(({ children, title, description }) => {
</body>
</html>
);
});
}) satisfies MiddlewareHandler as MiddlewareHandler;
3 changes: 2 additions & 1 deletion app/routes/all/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Fragment } from "hono/jsx";
import type { JSX } from "hono/jsx/jsx-runtime";
import { Heading } from "../../components/Heading";
import { rssClient } from "../../libs/rss/rss";

Expand All @@ -13,7 +14,7 @@ type PostEntry = {

const FIRST_BLOG_POST_YEAR = 2021;

export default function AllContent() {
export default function AllContent(): JSX.Element {
const posts = import.meta.glob<{
frontmatter: { title: string; date: string; published: boolean };
}>("../posts/*.mdx", { eager: true });
Expand Down
3 changes: 2 additions & 1 deletion app/routes/index.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { type FC, Fragment } from "hono/jsx";
import type { JSX } from "hono/jsx/jsx-runtime";
import { Heading } from "../components/Heading";
import { rssClient } from "../libs/rss/rss";

export default function Top() {
export default function Top(): JSX.Element {
return (
<>
<Heading title="Hi! I'm Yuto" />
Expand Down
3 changes: 2 additions & 1 deletion app/routes/posts/_renderer.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { MiddlewareHandler } from "hono";
import { jsxRenderer } from "hono/jsx-renderer";
import ContentWrapper from "../../islands/ContentWrapper";
import LikeButton from "../../islands/LikeButton";
Expand Down Expand Up @@ -26,4 +27,4 @@ export default jsxRenderer(({ children, Layout, frontmatter }) => {
<SnsButton title={_title} path={frontmatter?.path ?? ""} />
</Layout>
);
});
}) satisfies MiddlewareHandler as MiddlewareHandler;
106 changes: 106 additions & 0 deletions app/routes/posts/yossy-dev-isolated-declarations.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
---
title: "yossy.devでisolatedDeclationを有効にしてtscの速度を測る"
description: "Isolated Declarationsを有効にして、速度を測ってみました。"
date: "2024/12/16"
updatedAt: "2024/12/16"
path: "isolated-declarations"
published: true
---

[2024年 ユウトの一人アドベントカレンダー](https://adventar.org/calendars/9980)の16日目の記事です。

## Intro

[Isolated Declarations](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html#isolated-declarations)を有効にして、速度を測ってみました。

## 進め方

`"isolatedDeclarations": true`を設定するだけで良いです。プロジェクトによっては、`--declaration`も有効にする必要があるかもしれません。

あとは大量のエラーと戦うだけです。本ブログに関しては、以下のようなエラー数でした。

```
Errors Files
1 app/hooks/useDebounce.ts:3
1 app/libs/date.ts:7
3 app/libs/rss/rss.ts:14
1 app/libs/vite-remark-toc-plugin.ts:9
1 app/routes/_renderer.tsx:5
1 app/routes/all/index.tsx:16
1 app/routes/index.tsx:5
1 app/routes/posts/_renderer.tsx:6
1 app/routes/profile/index.tsx:10
1 app/routes/slides/index.tsx:7
1 app/routes/youtube/index.tsx:7
1 app/server.ts:4
1 vite.config.ts:14
```

ただvscodeは優秀なので、⌘ + .でいい感じに型をつけてくれるので、それにほぼ頼りました。
実際にはそれなりにちゃんとみたほうがいいと思います。

## 結果

実際にコード上でどんな変更をしたかは、[https://github.com/yossydev/yossy.dev/pull/78/files#diff-87e9aecc3694701f8eaef8ed0938745a89219c6d60a3b30f7ae9c44dc6761490](https://github.com/yossydev/yossy.dev/pull/78/files)で確認できます。

そして、`"typecheck:perfomance": "tsc --generateTrace . --incremental false --noEmit"`ってスクリプトを追加して、速度のチェックを行いました。

ここで生成されるtrace.jsonを、chrome://tracingの右上にあるLoadボタンで読み込ませて確認しています。

### 無効時

1. 804ms
2. 757ms
3. 822ms
4. 791ms

<table>
<thead>
<tr>
<th>
<img width="1194" alt="image" src="https://github.com/user-attachments/assets/7fbd920f-5955-4007-9630-11b89ce6c3ac" />
</th>
<th>
<img width="1210" alt="image" src="https://github.com/user-attachments/assets/b7c41e51-9015-497c-b2ea-2f4ad252cfb8" />
</th>
<th>
<img width="1198" alt="image" src="https://github.com/user-attachments/assets/bcc60ef4-100b-46c7-815b-4eb5ec11cb12" />
</th>
<th>
<img width="1200" alt="image" src="https://github.com/user-attachments/assets/6360fb36-bbc4-439c-8751-c0962c1d0acf" />
</th>
</tr>
</thead>
</table>

### 有効時

1. 865ms
2. 773ms
3. 773ms
4. 787ms

<table>
<thead>
<tr>
<th>
<img width="1200" alt="image" src="https://github.com/user-attachments/assets/16976162-56e4-4c82-a5d4-8becfe7c8ca7"/>
</th>
<th>
<img width="1200" alt="image" src="https://github.com/user-attachments/assets/e688d7d1-cf3b-4f7b-a48a-4498545482d3"/>
</th>
<th>
<img width="1198" alt="image" src="https://github.com/user-attachments/assets/beedf772-b673-43c1-ba69-692bee8c457a"/>
</th>
<th>
<img width="1203" alt="image" src="https://github.com/user-attachments/assets/3a119552-8d09-4ae6-8d00-32f46e99ee61"/>
</th>
</tr>
</thead>
</table>

全然コード量も多くないし、複雑な推論も必要な処理していないので誤差ですね。

## まとめ

Isolated Declarationsを有効化していくOSSや、サービスも多くなっていくと思うので、なんとなく素振りができてよかったです。
10 changes: 9 additions & 1 deletion app/routes/profile/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import type { Env } from "hono";
import type { FC } from "hono/jsx";
import type { H } from "hono/types";
import { createRoute } from "honox/factory";
import { Heading } from "../../components/Heading";
import { LINK } from "../../constants";
Expand Down Expand Up @@ -51,4 +53,10 @@ export default createRoute((c) => {
</>,
{ title: "Profile | yossy.dev" },
);
});
// biome-ignore lint/suspicious/noExplicitAny: <explanation>
// biome-ignore lint/complexity/noBannedTypes: <explanation>
}) satisfies [H<Env, any, {}, Response | Promise<Response>>] as [
// biome-ignore lint/suspicious/noExplicitAny: <explanation>
// biome-ignore lint/complexity/noBannedTypes: <explanation>
H<Env, any, {}, Response | Promise<Response>>,
];
3 changes: 2 additions & 1 deletion app/routes/slides/index.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Fragment } from "hono/jsx";
import type { JSX } from "hono/jsx/jsx-runtime";
import { Heading } from "../../components/Heading";
import { rssClient } from "../../libs/rss/rss";

const FIRST_SPEAKERDECK_YEAR = 2022;

export default function Slide() {
export default function Slide(): JSX.Element {
const yearlyBlogs = () => {
const data = [];
const thisYear = new Date().getFullYear();
Expand Down
3 changes: 2 additions & 1 deletion app/routes/youtube/index.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Fragment } from "hono/jsx";
import type { JSX } from "hono/jsx/jsx-runtime";
import { Heading } from "../../components/Heading";
import { rssClient } from "../../libs/rss/rss";

const FIRST_YOUTUBE_YEAR = 2024;

export default function Youtube() {
export default function Youtube(): JSX.Element {
const yearlyBlogs = () => {
const data = [];
const thisYear = new Date().getFullYear();
Expand Down
4 changes: 3 additions & 1 deletion app/server.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import type { Env, Hono } from "hono";
import { showRoutes } from "hono/dev";
import type { BlankSchema } from "hono/types";
import { createApp } from "honox/server";

const app = createApp();
const app: Hono<Env, BlankSchema, "/"> = createApp();

showRoutes(app);

Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"check": "biome check --apply .",
"check:ci": "biome ci .",
"typecheck": "tsc -p . --noEmit",
"typecheck:perfomance": "tsc --generateTrace . --incremental false --noEmit",
"create:post": "node ./app/libs/posts/generate-post.mjs",
"update-rss": "node ./app/libs/posts/rss-parser.mjs"
},
Expand All @@ -36,6 +37,7 @@
"rehype": "^13.0.1",
"remark": "^15.0.1",
"tailwindcss": "^3.4.1",
"typescript": "^5.7.2",
"unist-util-visit": "^5.0.0",
"vite": "^6.0.0",
"wrangler": "^3.57.0"
Expand Down
4 changes: 3 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
"skipLibCheck": true,
"types": ["@cloudflare/workers-types", "vite/client"],
"jsx": "react-jsx",
"jsxImportSource": "hono/jsx"
"jsxImportSource": "hono/jsx",
"declaration": true,
"isolatedDeclarations": true
}
}
8 changes: 5 additions & 3 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import client from "honox/vite/client";
import rehypeHighlight from "rehype-highlight";
import remarkFrontmatter from "remark-frontmatter";
import remarkMdxFrontmatter from "remark-mdx-frontmatter";
import { defineConfig } from "vite";
import type { UserConfigExport } from "vite";
import rehypeTOC from "./app/libs/vite-remark-toc-plugin";

const entry = "./app/server.ts";

export default defineConfig(({ mode }) => {
const defineConfig = ({ mode }: { mode: string }): UserConfigExport => {
if (mode === "client") {
return {
plugins: [client()],
Expand All @@ -38,4 +38,6 @@ export default defineConfig(({ mode }) => {
],
optimizeDeps: {},
};
});
};

export default defineConfig;
Loading