Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default variant from raspi-2 and EG builders. #5107

Merged
merged 4 commits into from
Mar 19, 2025
Merged

Remove default variant from raspi-2 and EG builders. #5107

merged 4 commits into from
Mar 19, 2025

Conversation

isarkis
Copy link
Member

@isarkis isarkis commented Mar 18, 2025 •
edited
Loading

We should rely on SB specific variants and to avoid confusion do away with default variants.

b/404612333

@isarkis
Remove sb16 variant from raspi-2 builder
5e87474 
SB16 is a default variant for raspi-2, so
we have duplicate builds.

b/404612333
niranjanyardi
niranjanyardi approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you removing evergreen-arm-hardfp/sbversion16 in a follow up ?

@isarkis
Copy link
Member Author

isarkis commented Mar 18, 2025

are you removing evergreen-arm-hardfp/sbversion16 in a follow up ?

we have to be careful with removing evergreen-arm-hardfp/sbversion16, are you sure our snapshot mechanism isn't consuming binary produced by this builder variant?

@isarkis isarkis requested a review from briantting March 18, 2025 23:23
@isarkis
Copy link
Member Author

isarkis commented Mar 18, 2025

are you removing evergreen-arm-hardfp/sbversion16 in a follow up ?

we have to be careful with removing evergreen-arm-hardfp/sbversion16, are you sure our snapshot mechanism isn't consuming binary produced by this builder variant?

I am adding Brian on this PR, we'll need him to confirm that snapshot mechanism isn't picking up these binaries. Screenshot 2025-03-18 at 4 22 04 PM).

@niranjanyardi
Copy link
Contributor

are you removing evergreen-arm-hardfp/sbversion16 in a follow up ?

we have to be careful with removing evergreen-arm-hardfp/sbversion16, are you sure our snapshot mechanism isn't consuming binary produced by this builder variant?

I am adding Brian on this PR, we'll need him to confirm that snapshot mechanism isn't picking up these binaries. Screenshot 2025-03-18 at 4 22 04 PM).

gotcha, they are dupes of each other : https://b.corp.google.com/issues/404612333#comment5
evergreen/hardfp & evergreen/sbversion16-hardfp . so would be good to remove one if possible

@kaidokert
Copy link
Member

kaidokert commented Mar 18, 2025 •
edited
Loading

so would be good to remove one if possible

Remove the one without the version in the string. All Evergreen builds should always have sbversion in them - including trunk ones.

@isarkis isarkis changed the title Remove sb16 variant from raspi-2 builder Remove default variant from raspi-2 and eg-hardfp builders. Mar 18, 2025
@isarkis isarkis changed the title Remove default variant from raspi-2 and eg-hardfp builders. Remove default variant from raspi-2 and EG builders. Mar 19, 2025
@isarkis isarkis added the on_device Trigger on-device tests label Mar 19, 2025
niranjanyardi
niranjanyardi reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you missed linux.json ?

@isarkis isarkis enabled auto-merge (squash) March 19, 2025 17:23
@isarkis isarkis disabled auto-merge March 19, 2025 17:23
@isarkis isarkis merged commit 9423400 into youtube:25.lts.1+ Mar 19, 2025
266 of 284 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niranjanyardi niranjanyardi niranjanyardi approved these changes

@kaidokert kaidokert Awaiting requested review from kaidokert

@briantting briantting Awaiting requested review from briantting

Assignees
No one assigned
Labels
on_device Trigger on-device tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isarkis @niranjanyardi @kaidokert