Implement metric for free cpu memory #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/390263164
|
I can't seem to access |
Bindings do not get generated at all and there is no build error if a semicolon is missing from the end of the interface definition.
|
I've fixed this, there was an issue where the binding for the extension function wasn't generating due to a missing semicolon (6fc9281) which gives no build error at all. Seems like it might be a bug in the Chromium IDL parser to not report that at all |
hlwarriner
requested changes
Mar 20, 2025
third_party/blink/renderer/core/cobalt/performance/performance_extensions.idl
Outdated
Show resolved
Hide resolved
third_party/blink/renderer/core/cobalt/performance/performance_extensions.idl
Outdated
Show resolved
Hide resolved
yell0wd0g
approved these changes
Mar 21, 2025
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Replaced the CVal Memory.CPU.Free from Cobalt 25 and earlier. b/390263164 (cherry picked from commit a6e5022)
andrewsavage1
added a commit
that referenced
this pull request
Mar 21, 2025
Refer to the original PR: #5116 Replaced the CVal Memory.CPU.Free from Cobalt 25 and earlier. b/390263164 Co-authored-by: Andrew Savage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the CVal Memory.CPU.Free from Cobalt 25 and earlier.
b/390263164