Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete TODO comments #5149

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Remove obsolete TODO comments #5149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/ozone/platform/starboard/gl_ozone_egl_starboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ bool GLOzoneEGLStarboard::LoadGLES2Bindings(
}

void GLOzoneEGLStarboard::CreateDisplayTypeIfNeeded() {
// TODO(b/371272304): Initialize hardware here if needed.
if (!have_display_type_) {
display_type_ = reinterpret_cast<void*>(SB_EGL_DEFAULT_DISPLAY);
have_display_type_ = true;
Expand Down
10 changes: 0 additions & 10 deletions ui/ozone/platform/starboard/ozone_platform_starboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ class OzonePlatformStarboard : public OzonePlatform {
}

std::unique_ptr<SystemInputInjector> CreateSystemInputInjector() override {
// TODO(b/371272304): Implement a system input injector for Starboard. This
// will likely be part of an event factory/dispatcher.
return nullptr;
}

Expand Down Expand Up @@ -123,8 +121,6 @@ class OzonePlatformStarboard : public OzonePlatform {
KeyboardLayoutEngineManager::SetKeyboardLayoutEngine(
keyboard_layout_engine_.get());

// TODO(b/371272304): Investigate if we need our own implementation of
// OverlayManager.
// It doesn't matter which of the UI or GPU creates | overlay_manager_ | and
// | surface_factory_ | in single-process mode.
if (!overlay_manager_) {
Expand All @@ -133,13 +129,7 @@ class OzonePlatformStarboard : public OzonePlatform {
// TODO(b/371272304): Investigate if we need our own implementation of
// InputController for things like gamepads or other atypical input devices.
input_controller_ = CreateStubInputController();
// TODO(b/371272304): Investigate if we need a more robust cursor factory or
// if we can continue using BitmapCursorFactory.
cursor_factory_ = std::make_unique<BitmapCursorFactory>();
// TODO(b/371272304): GpuPlatformSupportHost seems to be mainly for IPC
// between the Browser and GPU processes. Since Cobalt will be running as a
// single process, investigate if this is needed or if there's any
// additional features we might need to implement from there.
gpu_platform_support_host_.reset(CreateStubGpuPlatformSupportHost());

return true;
Expand Down
Loading