Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: avoid a deprecation warning in yt.load_sample on Python 3.12 #4745

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

neutrinoceros
Copy link
Member

PR Summary

Closes #4689

@neutrinoceros neutrinoceros added this to the 4.3.1 milestone Nov 18, 2023
@neutrinoceros neutrinoceros added bug infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup labels Nov 18, 2023
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neutrinoceros neutrinoceros merged commit abaf0e6 into yt-project:main Nov 27, 2023
11 checks passed
@neutrinoceros neutrinoceros deleted the test_cp312 branch November 27, 2023 21:56
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: CPython 3.12 compatibility (progress tracker)
2 participants