Skip to content

Commit

Permalink
[#26273] YSQL: Remove YB_TODO in pg_proc.dat
Browse files Browse the repository at this point in the history
Summary:
YB commit ced7c32 partially imported PG commit ab0dfc961b6a821f23d9c40c723d11380ce195a6 to add support for the `pg_stat_progress_create_index` view.
The YB master commit changed the pg_proc definition for pg_stat_get_progress_info to include 7 new fields (param11, param12.... param17) that are used by the pg_stat_progress_create_index view.
However, the original PG commit adds three extra fields (param18, param19, param20). It is unclear what these fields are for as they are not used in any of the existing pg_stat_progress_* views. Moreover, no call to pgstat_progress_update_param(...) in the codebase operates on indices that would correspond to these params.
Regardless, there is nothing to do here, as the pg_stat_progress_* view definitions remain unchanged, and the major version upgrade will handle the changes made to the pg_proc entry appropriately.
Jira: DB-15619

Test Plan: Jenkins

Reviewers: telgersma, hsunder

Reviewed By: telgersma

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D42215
  • Loading branch information
fizaaluthra committed Mar 4, 2025
1 parent 92b3be7 commit 9c59cfb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/postgres/src/include/catalog/pg_proc.dat
Original file line number Diff line number Diff line change
Expand Up @@ -5368,10 +5368,6 @@
proargmodes => '{i,o,o,o,o,o,o}',
proargnames => '{db_oid,db_oid,backend_pid,query_text,termination_reason,query_start,query_end}',
prosrc => 'yb_pg_stat_get_queries'},
# YB_TODO(neil) talk to Fizaa about her changes for "pg_stat_get_progress_info".
# commit ced7c32846e4adbe2a93ca20fc64fd648bec8851
# Author: Fizaa Luthra <[email protected]>
# Date: Fri Jan 27 12:14:34 2023 -0500
{ oid => '3318',
descr => 'statistics: information about progress of backends running maintenance command',
proname => 'pg_stat_get_progress_info', prorows => '100', proretset => 't',
Expand Down

0 comments on commit 9c59cfb

Please sign in to comment.