Add validator for leader lease to be larger than heartbeat interval

[in3xes]

This PR fixes #1348

It brings in delayed validators to make sure raft_heartbeat_interval_ms is less than leader_lease_duration_ms

[CLAassistant]

All committers have signed the CLA.

[hari90]

Suggested change

	"Must be greater than raft_heartbeat_interval_ms"));
	yb::Format("Must be greater than or equal to raft_heartbeat_interval_ms: $0", FLAGS_raft_heartbeat_interval_ms)));

[hari90]

Suggested change

	"Must be less than leader_lease_duration_ms"));
	yb::Format("Must be less than or equal to leader_lease_duration_ms: $0", FLAGS_leader_lease_duration_ms)));

[hari90]

Can you please try these cases and paste the output in the comment description as a test:

# Success cases
./build/latest/bin/yb-master --raft_heartbeat_interval_ms 100 --leader_lease_duration_ms 100  --version
./build/latest/bin/yb-master --raft_heartbeat_interval_ms 100 --leader_lease_duration_ms 50  --version
./build/latest/bin/yb-master --leader_lease_duration_ms 100 --raft_heartbeat_interval_ms 100  --version
./build/latest/bin/yb-master --leader_lease_duration_ms 50 --raft_heartbeat_interval_ms 100  --version

./build/latest/bin/yb-tserver --raft_heartbeat_interval_ms 100 --leader_lease_duration_ms 100  --version
./build/latest/bin/yb-tserver --raft_heartbeat_interval_ms 100 --leader_lease_duration_ms 50  --version
./build/latest/bin/yb-tserver --leader_lease_duration_ms 100 --raft_heartbeat_interval_ms 100  --version
./build/latest/bin/yb-tserver --leader_lease_duration_ms 50 --raft_heartbeat_interval_ms 100  --version

# Failure cases
./build/latest/bin/yb-master --raft_heartbeat_interval_ms 50 --leader_lease_duration_ms 100  --version
./build/latest/bin/yb-master --leader_lease_duration_ms 100 --raft_heartbeat_interval_ms 50  --version

./build/latest/bin/yb-tserver --raft_heartbeat_interval_ms 50 --leader_lease_duration_ms 100  --version
./build/latest/bin/yb-master --leader_lease_duration_ms 100 --raft_heartbeat_interval_ms 50  --version

[hari90]

Please change
DEFINE_UNKNOWN_int32(leader_lease_duration_ms
to
DEFINE_NON_RUNTIME_int32(leader_lease_duration_ms