fix: only inject node description if its empty in the yaml

z3z1ma · Jan 17, 2025 · 2c77360 · 2c77360
1 parent 21f5264
commit 2c77360
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/.changes/unreleased/Fixed-20250117-001238.yaml b/.changes/unreleased/Fixed-20250117-001238.yaml
@@ -0,0 +1,3 @@
+kind: Fixed
+body: Only inject node description if yaml description is empty
+time: 2025-01-17T00:12:38.400622872-07:00
diff --git a/src/dbt_osmosis/core/osmosis.py b/src/dbt_osmosis/core/osmosis.py
@@ -1387,10 +1387,8 @@ def _sync_doc_section(
     We assume node is the single source of truth, so doc_section is replaced.
     """
     logger.debug(":arrows_counterclockwise: Syncing doc_section with node => %s", node.unique_id)
-    if node.description:
+    if node.description and not doc_section.get("description"):
         doc_section["description"] = node.description
-    else:
-        doc_section.pop("description", None)
 
     current_columns: list[dict[str, t.Any]] = doc_section.setdefault("columns", [])
     incoming_columns: list[dict[str, t.Any]] = []

diff --git a/uv.lock b/uv.lock