-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fast-json-stringify optional #84
Make fast-json-stringify optional #84
Conversation
We can also try https://docs.npmjs.com/files/package.json#optionaldependencies |
I will try reviewing this weekend. |
I would prefer to extract the json to a separate package. I am not a fan of having it integrated since there are very limited advantages to having it included. It would also be natural to expose graphql query to binary. @boopathi wdyt? |
Yes. I also agree with the caveats mentioned in the description. I think we can start with this and think about a model after we start including serializing to other formats like binary. |
I agree to this. I'm actually ok with not even having that separate package in the meantime. We can still keep
Closing. |
Close #83
This is still up to discussion and may be closed if it deems likewise. This is a breaking change
Caveat:
queryToJSONSchema
is tightly coupled withfast-json-stringify
(nullable
prop)fast-json-stringify
has breaking change.