Remove fast-json-stringify and allows customJSONSerializer to be a function

[hoangvvo]

This PR allows options.customJSONSerializer to be a function to be called with CompilationContext to returns a serializer function. It will be a breaking change.

Something like queryToJSONSchema in json.ts is not a concern of this package and should be reimplemented in userland.

import { queryToJSONSchema } from '../user-land/json';

compileQuery(schema, document, "", {
  customJSONSerializer: (context) => {
    const jsonSchema = queryToJSONSchema(context);
    return fastJson(jsonSchema);
  }
});

Why

• fast-json-stringify is way too large if graphql-jit is ever used in browser.
• We pin fast-json-stringify at v1 which misses out a lot of features from v2. User should get to choose what JSON serializer to use.

Fix #83

[hoangvvo]

I tried to publish it as a fork. Bundle size went down from 226.9 kb -> 70.3 kb (~70%)

https://bundlephobia.com/result?p=@hoangvvo/[email protected]

compared to

https://bundlephobia.com/[email protected]

[mcollina]

lgtm

[ruiaraujo]

Suggested change

	- `customJSONSerializer` {function, default: false} - A function to be called with [`CompilationContext`](https://github.com/zalando-incubator/graphql-jit/blob/master/src/execution.ts#L87) to produce also a JSON serializer function. The default stringifier function is `JSON.stringify`
	- `customJSONSerializer` {function, default: undefined} - A function to be called with [`CompilationContext`](https://github.com/zalando-incubator/graphql-jit/blob/master/src/execution.ts#L87) to produce also a JSON serializer function. The default stringifier function is `JSON.stringify`

[hoangvvo]

In code, the default value is false. Is this okay to write it as undefined in the doc (even though it does not matter actually)

graphql-jit/src/execution.ts

Line 214 in 8b678a1

customJSONSerializer: false,

[ruiaraujo]

Isn't this equivalent to removing the feature fully? The main difference is that you get access to the CompilationContext. Do you find it valuable?

[hoangvvo]

Sorry for the late response. It is helpful to me, but I'm not sure if others are depending on it (in which case let's drop this PR).

By the name customJSONSerializer, the option should allow actually "custom" JSON serializer, not specifically the built in one.

Pretty much my reasons have already been mentioned above in this PR. Whatever in json.ts also seems to be "out of the scope" of this package.

[ruiaraujo]

@boopathi what do you think about this? We could move to a mutiple package setup and add the JSON stringifier with the idea of later adding a protobuf one for example.

[boopathi]

yes I think that's a good idea. we can add and move a few other things as well.

[hoangvvo]

Are we still interested in proceeding in this direction? I would love to reopen another PR after discussing the good approach forward. Thanks!