This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Marshal the response body into HttpServiceError #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
Deeds67,
gouthampradhan,
itachi3 and
xjrk58
as code owners
Signed-off-by: Matthew de Detrich <[email protected]>
mdedetrich
force-pushed
the
marshal-body-into-http-service-error
branch
from
cde5876
to
86975de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the #133 PR we fixed a regression which was introduced due to Nakadi not properly following the
Problemspec (see #134).Unfortunately in that PR we also lose any context of the response because
HttpServiceErrordidn't contain the response body and we had to discard the response body due to the streaming nature of akka-streams.This PR fixes this.