This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Update to Swift 5.0 #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, and thanks for your support. I think we should wait with updating to Swift 5 until 4.2 is no longer supported by the newest Xcode version. That way SwiftMonkey can be used by more people. |
|
Sure, feel free to close this PR, if it's not needed right now 👍 |
|
Closing this PR as the migration to Swift 5 is not yet required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibility for Xcode 10.2 and Swift 5.0 and mainly fixes Xcode warnings.
I tried to run the example project in Xcode 10.2 but it seems like
monkey.addDefaultXCTestPrivateActions()is not working in this Xcode Version. Usingmonkey.addDefaultUIAutomationActions()works fine.I created an issue for this #75, but this is not related to this pull request because you can reproduce this issue in Xcode 10.2 with both versions Swift 4.2 and Swift 5.0.