First draft of Servlet 2.5 support #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.text.DateFormat; | ||
| import java.text.SimpleDateFormat; |
There was a problem hiding this comment.
SimpleDateFormat?
There was a problem hiding this comment.
I organized imports again. Should be gone now.
There was a problem hiding this comment.
Yes, for me it is a red flag because it is not thread safe and java 8 has better alternative
| @Override | ||
| public void addDateHeader(final String name, final long date) { | ||
| super.addDateHeader(name, date); | ||
| addMultiMapHeader(name, format(date)); |
There was a problem hiding this comment.
format could be simplified with Instant.ofEpochMilli() instead of new Date()
added 2 commits
November 9, 2017 11:13
|
@hanfak I consulted with some colleagues about this. We took a look at the code and discussed what still would need to be done. The conclusion that we came to is that we don't see the value. It would increase the complexity of logbook disproportionately to the gained benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172
Replaces #174
@hanfak I made your tests pass and changed the implementation from being reflection-based to two distinct implementations. Code is 100% covered, but I can't verify it reliably against servlet api 2.5 since that would require to rewrite almost all tests from the logbook-servlet module.