remove streams delete and extend unit tests #2737
Open
+105
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2733 fixed a bug with stream duplicates created on every operator restart. To facilitate the cleanup the operator was deleting every extra stream it found based on the filter labels.
In general, the operator should be careful with what it deletes. Therefore this PR removes the delete call again assuming that duplicates should not exist only if somebody adds them manually with the same labels which is unlikely to happen. Sorting is not supported in go client so we would not be able to tell which stream gets synced in the cluster struct (same for deletions).
I have split the update streams unit test to have a dedicated test only for removal.