proxy: trace response body size and request header length #3421
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
proxy/tracing-headers-length
branch
2 times, most recently
from
9ffea21 to
36bfbdc
Compare
Add response body size and request headers length rounded to the next power of two as proxy span tags. The rounding is done to reduce cardinality of the tags and avoid introducing new configuration parameter. Since it is tricky to measure request header length in bytes it is calculated as the sum of lengths of header names and values. Note that OpenTelemetry [Semantic Conventions for HTTP Spans](https://opentelemetry.io/docs/specs/semconv/http/http-spans/) define the following related attributes: * experimental [http.response.body.size](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-response-body-size) for body size in bytes * stable [http.request.header.<key>](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-request-header) for header value Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
proxy/tracing-headers-length
branch
from
36bfbdc to
704c996
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add response body size and request headers length rounded to the next power of two as proxy span tags.
The rounding is done to reduce cardinality of the tags and avoid introducing a new configuration parameter.
Since it is tricky to measure request header length in bytes it is calculated as the sum of lengths of header names and values.
Note that OpenTelemetry Semantic Conventions for HTTP Spans define the following related attributes:
http.response.body.sizefor body size in byteshttp.request.header.<key>for header value