Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run macOS CI on intel based runners + pin max clang version #528

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 19, 2024

GitHub updated the latest macOS runners to be arm-based, causing the CI to fail. This makes sure the existing CI is using intel based macOS runners - we can always add support for arm-based testing in a follow up PR.

Fixes #527

@dstansby
Copy link
Contributor Author

@zarrdevelopers any chance someone could approve the workflows here?

@MSanKeys963
Copy link
Member

@joshmoore or @jakirkham, please approve the workflows.

@jakirkham
Copy link
Member

Looks like Josh did that, but CI is failing on macOS. Maybe we are still missing something?

@dstansby
Copy link
Contributor Author

dstansby commented May 22, 2024

the last time the macOS wheel builds were working they were using the macos-12 image, so I've updated that for now. Can someone approve workflows for me again?

@joshmoore
Copy link
Member

Launched

@dstansby
Copy link
Contributor Author

dstansby commented May 22, 2024

For debugging, https://github.com/zarr-developers/numcodecs/actions/runs/8027488593 is a build on macOS 12 that passed.

@jakirkham
Copy link
Member

Approved again

David, if you send a small fix PR to Numcodecs (maybe a small doc fix?), we could merge that, which should green light CI to run on your PRs. That way we are not holding you up in your testing efforts

Also thank you for digging into this issue! 🙏

@dstansby
Copy link
Contributor Author

Ah good idea! Here we go: #530

At least it looks like I fixed the issue here, it was the max version of clang that needed pinning.

@dstansby dstansby changed the title Run macOS CI on intel based runners Run macOS CI on intel based runners + pin max clang version May 23, 2024
@dstansby
Copy link
Contributor Author

Great, this should finally be fixed now!

Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@normanrz
Copy link
Member

Codecov reporting is flaky. Could you try to add a new (empty) commit to trigger it again?

@dstansby
Copy link
Contributor Author

I've pinned numpy here too just to get the tests working, I can work on numpy 2.0 support in another PR.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (4abe4be) to head (bd3a7a7).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   99.91%   99.91%   -0.01%     
==========================================
  Files          59       59              
  Lines        2323     2320       -3     
==========================================
- Hits         2321     2318       -3     
  Misses          2        2              

see 2 files with indirect coverage changes

@dstansby
Copy link
Contributor Author

Fab, this is all green now!

@normanrz normanrz merged commit 7b2ce5e into zarr-developers:main Jun 19, 2024
27 checks passed
@dstansby dstansby deleted the macos-ci branch June 19, 2024 09:17
@jakirkham
Copy link
Member

Thanks all! 🙏

DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/numcodecs that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numcodecs failing to build on OSX
5 participants