-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run macOS CI on intel based runners + pin max clang version #528
Conversation
@zarrdevelopers any chance someone could approve the workflows here? |
@joshmoore or @jakirkham, please approve the workflows. |
Looks like Josh did that, but CI is failing on macOS. Maybe we are still missing something? |
the last time the macOS wheel builds were working they were using the macos-12 image, so I've updated that for now. Can someone approve workflows for me again? |
Launched |
For debugging, https://github.com/zarr-developers/numcodecs/actions/runs/8027488593 is a build on macOS 12 that passed. |
Approved again David, if you send a small fix PR to Numcodecs (maybe a small doc fix?), we could merge that, which should green light CI to run on your PRs. That way we are not holding you up in your testing efforts Also thank you for digging into this issue! 🙏 |
Ah good idea! Here we go: #530 At least it looks like I fixed the issue here, it was the max version of clang that needed pinning. |
Great, this should finally be fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov reporting is flaky. Could you try to add a new (empty) commit to trigger it again? |
I've pinned numpy here too just to get the tests working, I can work on numpy 2.0 support in another PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 99.91% 99.91% -0.01%
==========================================
Files 59 59
Lines 2323 2320 -3
==========================================
- Hits 2321 2318 -3
Misses 2 2 |
Fab, this is all green now! |
Thanks all! 🙏 |
GitHub updated the latest macOS runners to be arm-based, causing the CI to fail. This makes sure the existing CI is using intel based macOS runners - we can always add support for arm-based testing in a follow up PR.
Fixes #527