Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary dependency on mock #643

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

avalentino
Copy link
Contributor

@avalentino avalentino commented Nov 16, 2024

Mock is only used in docs/conf.py but the unittest.mock from the standard library is used so an external mock dependency is not needed.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@dstansby dstansby added this to the 0.14.1 milestone Nov 16, 2024
@jakirkham
Copy link
Member

Lovely! Thank you Antonio 🙏

@jakirkham jakirkham enabled auto-merge (squash) November 17, 2024 00:11
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (ad1ad67) to head (954c833).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          62       62           
  Lines        2708     2708           
=======================================
  Hits         2705     2705           
  Misses          3        3           

@dstansby dstansby disabled auto-merge November 18, 2024 11:39
@dstansby dstansby merged commit 39e6128 into zarr-developers:main Nov 18, 2024
25 of 26 checks passed
@avalentino avalentino deleted the bugfix/nomock branch November 18, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants