-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup PCodec
soft dependency
#647
base: main
Are you sure you want to change the base?
Conversation
0a8d9e2
to
e7acf8d
Compare
e7acf8d
to
d1f76fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 99.92% 99.85% -0.08%
==========================================
Files 62 62
Lines 2761 2759 -2
==========================================
- Hits 2759 2755 -4
- Misses 2 4 +2
|
@dstansby could you please review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - do you want to add a changelog if this changes behaviour for users?
7808aeb
to
5ca0221
Compare
PCodec
soft dependency handlingPCodec
soft dependency
Resolved conflicts and added a changelog entry |
@@ -27,6 +27,8 @@ Fixes | |||
~~~~~ | |||
* Fixes issue with ``Delta`` Zarr 3 codec not working with ``astype``. | |||
By :user:`Norman Rzepka <normanrz>`, :issue:`664` | |||
* Cleanup ``PCodec`` soft dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Cleanup ``PCodec`` soft dependency. | |
* Cleanup ``PCodec`` soft dependency. | |
Previously importing ``numcodecs.pcodec`` would work if ``pcodec`` is not installed, | |
but now it will fail to import. This mirrors the behaviour of other optional dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have something that describes what's changed to users - I've left a suggesiton above
As with other soft dependencies in Numcodecs, the pattern is to attempt to
import
them and if their dependencies cannot be resolved skip them. Have applied this pattern toPCodec
to be consistent with the other optional codec dependencies.TODO: