Skip to content

Error on invalid store mode #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

This avoids instances where mode='r' could be passed, by the resulting array is not read-only. Fixes #2949

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 18, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label May 18, 2025
@dstansby dstansby marked this pull request as ready for review May 18, 2025 16:27
@dstansby dstansby added this to the 3.0.8 milestone May 19, 2025
@d-v-b
Copy link
Contributor

d-v-b commented May 19, 2025

this looks good to me, curious to hear your thoughts @jhamman since you are the mode architect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array.read_only incorrect
2 participants