Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example with RDF Data Cube & Linechart #8

Merged
merged 5 commits into from
Apr 15, 2019
Merged

Example with RDF Data Cube & Linechart #8

merged 5 commits into from
Apr 15, 2019

Conversation

ktk
Copy link
Member

@ktk ktk commented Apr 14, 2019

Line chart example with Highcharts & data from RDF Data Cubes from City of Zurich, with help from @bergos .

Some remaining questions:

  • I guess one could get rid of data on line 39 completely and do the mapping directly from the d3-csv structure on line 58 and 75
  • I get an error on console, although it seems to render properly: TypeError: Highcharts.chart(...) is not a function
  • I added the libs from CDNs, one might want to roll back to local files for our demo

It is not using d3 itself as the boilerplate for that seems to be quite large, but this would IMO fix issue #4

@ktk ktk requested review from l00mi, bergos and vhf April 14, 2019 12:52
@vhf
Copy link
Contributor

vhf commented Apr 14, 2019

Here are suggestions: ktk#1

@ktk
Copy link
Member Author

ktk commented Apr 15, 2019

Except the CDN stuff this is now clean, I think we should still add that as an example, even if it is not directly d3. @l00mi can still do a version like that for d3. But at least people get an idea of how to use it.

@l00mi
Copy link
Contributor

l00mi commented Apr 15, 2019

Fine by me, just lets reflect that in the title of the file and add a "highchartslib" somewhere?

@ktk ktk merged commit 4ddd440 into zazuko:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants